Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring the Service IP Family policy to make it dual-stack #252

Merged
merged 5 commits into from
Feb 23, 2025

Conversation

rm3l
Copy link
Contributor

@rm3l rm3l commented Feb 20, 2025

Description of the change

This PR allows users to configure the ipFamilyPolicy and ipFamilies of the Kubernetes Service.
By default, Kubernetes Services are created to work only on the IPv4 stack.
People on a dual-stack network should be able to specify the policy they want.

See https://kubernetes.io/docs/concepts/services-networking/dual-stack/#services for reference.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@rm3l rm3l requested a review from a team as a code owner February 20, 2025 10:11
rm3l added 5 commits February 20, 2025 11:14
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
@rm3l rm3l force-pushed the feat/service-dual-stack-ip-families branch from 790a708 to 006e28d Compare February 20, 2025 10:14
@ChrisJBurns
Copy link
Contributor

Thanks @rm3l approved so we can get some CI assurance!

@rm3l
Copy link
Contributor Author

rm3l commented Feb 20, 2025

Thanks @rm3l approved so we can get some CI assurance!

Thanks @ChrisJBurns !
So the CI passed, and I verified in the logs that it tested the values file added in this PR - see https://github.com/backstage/charts/actions/runs/13432933533/job/37536257929?pr=252#step:10:1968

Please take a look. Thanks.

@ChrisJBurns
Copy link
Contributor

Nice! @rm3l, good work!

Happy to merge if you guys are @backstage/helm-charts-maintainers

@ChrisJBurns ChrisJBurns merged commit 2df03a9 into backstage:main Feb 23, 2025
3 checks passed
@rm3l rm3l deleted the feat/service-dual-stack-ip-families branch February 23, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants